CB-5511 fix: pagination #2906
CB-5511 fix: pagination #2906
Conversation
| @@ -240,6 +242,7 @@ export class UsersResource extends CachedMapResource<string, AdminUser, UserReso | |||
| } | |||
|
|
|||
| const usersList: AdminUser[] = []; | |||
| const pages: Parameters<typeof this.offsetPagination.setPage>[] = []; | |||
There was a problem hiding this comment.
lets create a separate type for that
There was a problem hiding this comment.
im not sure that we need it, because we don't and can't use it anywhere to declare exact implementation, instead we have several places when we need to "delay" setPage call (we want to call it synchronously in same action with data mutation and after data mutation)
Probably we can want in future ability to delay setPage call via API but not with this array of arguments + for each + call
| from: true, | ||
| to: true, |
There was a problem hiding this comment.
why true?
may be observable also?
There was a problem hiding this comment.
it's shorthand for from: observable
| // if (pageKey) { | ||
| // metadata.offsetPage = observable({ | ||
| // ...metadata.offsetPage, | ||
| // pages: expandOffsetPageRange(metadata.offsetPage?.pages || [], pageKey.options, false), | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
what about this logic? should it be deleted at all or handled in a different way according to new api?
now I can see that pages wont be marked as loaded. is it correct?
There was a problem hiding this comment.
we will delete it, pages have different logic
| @@ -114,39 +114,48 @@ export function limitOffsetPages(pages: IResourceOffsetPage[], limit: number): I | |||
| return result; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
really hard to read what is going on here. please at least TODO to make it more readable
There was a problem hiding this comment.
thanks, removed (it's not in use anymore)
| setPageEnd(key: ResourceAlias<TKey, Readonly<ICachedResourceOffsetPageOptions>>, hasNextPage: boolean): void { | ||
| const count = key.options.offset + key.options.limit; | ||
| setPage(key: ResourceAlias<TKey, Readonly<ICachedResourceOffsetPageOptions>>, items: any[], hasNextPage: boolean) { | ||
| items = [...items]; |
| from: true, | ||
| to: true, |
| from: true, | ||
| to: true, | ||
| items: observable.shallow, | ||
| outdated: observable, |
There was a problem hiding this comment.
observable.ref maybe? as its a boolean
There was a problem hiding this comment.
there is no difference for primitives actually observable and observable.ref will have same effect (and true)
No description provided.